Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo error without break the API of the library #171

Open
vincenzopalazzo opened this issue Oct 1, 2021 · 2 comments
Open

Fixed typo error without break the API of the library #171

vincenzopalazzo opened this issue Oct 1, 2021 · 2 comments
Labels

Comments

@vincenzopalazzo
Copy link
Owner

vincenzopalazzo commented Oct 1, 2021

I'm a very bad person when it is the moment to write things, and my library contains a lot of typos.

If someone wants to contribute to this repository, you can start to read the code, and maybe fix some typos. However, this repository is used in a big project like JMars where the solidity of the API is more important than the typos.

The change of the API can be discussed in the discussion section.

If you want assigned this issue, please leave a comment below

Good luck :)

@berry120
Copy link

berry120 commented Oct 1, 2021

Hey, I've created a PR to fix a bunch of these 👍

@vincenzopalazzo
Copy link
Owner Author

HI @berry120,

Thanks, I will review for the end of the day, because now I'm traveling.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants