Release 0.6.2.1.3 (#258)

* fix marginal PIT for discrete variables (fixes #257) * prep release * fix URL in README * fix sprintf() call for CRAN checks * unname macro arguments / Werror=unused-parameters Co-authored-by: tnagler <thomas.nagler@tum.de>
vinecopulib · Jan 19, 2023 · 8dd8846 · 8dd8846
1 parent 826e736
commit 8dd8846
Show file tree

Hide file tree

Showing 75 changed files with 408 additions and 388 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -32,12 +32,12 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - uses: r-lib/actions/setup-r@master
+      - uses: r-lib/actions/setup-r@v2
         with:
           r-version: ${{ matrix.config.r }}
           http-user-agent: ${{ matrix.config.http-user-agent }}
 
-      - uses: r-lib/actions/setup-pandoc@master
+      - uses: r-lib/actions/setup-pandoc@v2
 
       - name: Query dependencies
         run: |
@@ -48,7 +48,7 @@ jobs:
 
       - name: Cache R packages
         if: runner.os != 'Windows'
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: ${{ env.R_LIBS_USER }}
           key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-${{ hashFiles('.github/depends.Rds') }}

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: rvinecopulib
 Type: Package
 Title: High Performance Algorithms for Vine Copula Modeling
-Version: 0.6.2.1.2
+Version: 0.6.2.1.3
 Authors@R: c(
         person("Thomas", "Nagler",, "info@vinecopulib.org", role = c("aut", "cre")),
         person("Thibault", "Vatter",, "info@vinecopulib.org", role = c("aut"))

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,8 @@
-# rvinecopulib 0.6.2.1.1 (October 16, 2022)
+# rvinecopulib 0.6.2.1.3 (December 3, 2022)
+
+- fix marginal PIT for discrete variables (see issue #257, thanks @rplzzz)
+
+# rvinecopulib 0.6.2.1.2 (October 16, 2022)
 
 - fix warning about C++17 attribute extension 'nodiscard' (#255)
 

diff --git a/R/vine.R b/R/vine.R
@@ -175,7 +175,7 @@ compute_pseudo_obs <- function(data, vine) {
         lv <- as.numeric(data[, k]) - 1
         lv0 <- which(lv == 0)
         lv[lv0] <- 1
-        xlv <- factor(levels(data[, k])[lv], levels = levels(data[, k]))
+        xlv <- ordered(levels(data[, k])[lv], levels = levels(data[, k]))
         u_sub[, k] <- eval_one_dpq(xlv, vine$margins[[k]])
         u_sub[lv0, k] <- 0
       }

diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ rvinecopulib
 
 Vine copulas are a flexible class of dependence models consisting of bivariate 
 building blocks (see e.g., Aas et al., 2009). You can find a comprehensive 
-list of publications and other materials on [vine-copula.org](https://www.math.cit.tum.de/en/statistics/statistics/research/vine-copula-models/).
+list of publications and other materials on [vine-copula.org](https://www.math.cit.tum.de/math/forschung/gruppen/statistics/vine-copula-models/).
 
 This package is the [R](https://cran.r-project.org/) API to the C++ library 
 [vinecopulib](https://github.com/vinecopulib/vinecopulib), a header-only 

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,14 +1,12 @@
-Fixes warnings issued by clang-14's -Wc++17-attribute-extensions.
-
 ## Test environments
 
 * CRAN win builder (devel)
 * Windows Server 2019 (release)
 * macOS (release)
 * ubuntu 20.04 (release, oldrel, devel)
 
-## R CMD check results
-
-There were no ERRORs or WARNINGs. 
+## Check status summary
 
-## Reverse dependencies
+                NOTE OK
+Source packages    1  0
+Reverse depends    5  4
diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/LICENSE-text.html b/docs/LICENSE-text.html
diff --git a/docs/authors.html b/docs/authors.html
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/news/index.html b/docs/news/index.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -1,6 +1,6 @@
-pandoc: '2.18'
+pandoc: 2.19.2
 pkgdown: 2.0.6
 pkgdown_sha: ~
 articles: {}
-last_built: 2022-10-16T15:23Z
+last_built: 2022-12-03T13:09Z
 
diff --git a/docs/reference/Rplot001.png b/docs/reference/Rplot001.png
diff --git a/docs/reference/Rplot002.png b/docs/reference/Rplot002.png
diff --git a/docs/reference/Rplot003.png b/docs/reference/Rplot003.png
diff --git a/docs/reference/Rplot004.png b/docs/reference/Rplot004.png
diff --git a/docs/reference/Rplot005.png b/docs/reference/Rplot005.png
diff --git a/docs/reference/Rplot006.png b/docs/reference/Rplot006.png
diff --git a/docs/reference/as_rvine_structure.html b/docs/reference/as_rvine_structure.html
diff --git a/docs/reference/bicop-1.png b/docs/reference/bicop-1.png
diff --git a/docs/reference/bicop-2.png b/docs/reference/bicop-2.png
diff --git a/docs/reference/bicop.html b/docs/reference/bicop.html
diff --git a/docs/reference/bicop_dist-3.png b/docs/reference/bicop_dist-3.png
diff --git a/docs/reference/bicop_dist.html b/docs/reference/bicop_dist.html
diff --git a/docs/reference/bicop_methods-1.png b/docs/reference/bicop_methods-1.png
diff --git a/docs/reference/bicop_methods.html b/docs/reference/bicop_methods.html
diff --git a/docs/reference/getters.html b/docs/reference/getters.html
diff --git a/docs/reference/index.html b/docs/reference/index.html
diff --git a/docs/reference/mBICV.html b/docs/reference/mBICV.html
diff --git a/docs/reference/pairs_copula_data-1.png b/docs/reference/pairs_copula_data-1.png
diff --git a/docs/reference/pairs_copula_data.html b/docs/reference/pairs_copula_data.html
diff --git a/docs/reference/par_to_ktau.html b/docs/reference/par_to_ktau.html
diff --git a/docs/reference/plot.bicop_dist.html b/docs/reference/plot.bicop_dist.html
diff --git a/docs/reference/plot.rvine_structure-1.png b/docs/reference/plot.rvine_structure-1.png
diff --git a/docs/reference/plot.rvine_structure-2.png b/docs/reference/plot.rvine_structure-2.png
diff --git a/docs/reference/plot.rvine_structure-3.png b/docs/reference/plot.rvine_structure-3.png
diff --git a/docs/reference/plot.rvine_structure-4.png b/docs/reference/plot.rvine_structure-4.png
diff --git a/docs/reference/plot.rvine_structure.html b/docs/reference/plot.rvine_structure.html
diff --git a/docs/reference/plot.vinecop_dist-1.png b/docs/reference/plot.vinecop_dist-1.png
diff --git a/docs/reference/plot.vinecop_dist-2.png b/docs/reference/plot.vinecop_dist-2.png
diff --git a/docs/reference/plot.vinecop_dist-3.png b/docs/reference/plot.vinecop_dist-3.png
diff --git a/docs/reference/plot.vinecop_dist-4.png b/docs/reference/plot.vinecop_dist-4.png