Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove [nodiscard] flags (C++17 attribute extension) #255

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Remove [nodiscard] flags (C++17 attribute extension) #255

merged 3 commits into from
Oct 16, 2022

Conversation

tnagler
Copy link
Collaborator

@tnagler tnagler commented Oct 16, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022 •
edited
Loading

Codecov Report

Base: 94.48% // Head: 94.48% // No change to project coverage 👍

Coverage data is based on head (e34ec8c) compared to base (66c3e7a).
Patch has no changes to coverable lines.

❗ Current head e34ec8c differs from pull request most recent head 55e173a. Consider uploading reports for the commit 55e173a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #255   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          16       16           
  Lines        1560     1560           
=======================================
  Hits         1474     1474           
  Misses         86       86

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tnagler tnagler merged commit 01920a3 into dev Oct 16, 2022
@tnagler tnagler deleted the remove-nodiscard branch October 16, 2022 16:03
@tnagler tnagler mentioned this pull request Oct 16, 2022
Merged
tnagler added a commit that referenced this pull request Oct 17, 2022
@tnagler
Remove [nodiscard] flags (C++17 attribute extension) (#255) (#256)
826e736 
* pull vcl sources

* bump version + NEWS

* update website

Co-authored-by: tnagler <thomas.nagler@tum.de>

Co-authored-by: tnagler <thomas.nagler@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnagler @codecov-commenter