Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt a confirmation before clearing all cookies #5

Open
vinitshahdeo opened this issue Oct 1, 2019 · 11 comments
Open

Prompt a confirmation before clearing all cookies #5

vinitshahdeo opened this issue Oct 1, 2019 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs Solve the issue and raise your first PR
Projects
HacktoberFest 2019

Comments

@vinitshahdeo
Copy link
Owner

Clearing all cookies can be incidental.

So, adding an alert box to confirm after clicking CLEAR ALL COOKIES button can avoid this.

Note - Please do not make any changes in CSS and other files.
@vinitshahdeo vinitshahdeo added help wanted Extra attention is needed hacktoberfest labels Oct 1, 2019
@AnnaelleS
Copy link

Hello ! I would like to try and solve this issue, is that okay for you ? :)

@vinitshahdeo
Copy link
Owner Author

@AnnaelleS
Yeah sure, please raise the PR once done.

@vinitshahdeo vinitshahdeo added the good first issue Good for newcomers label Oct 1, 2019
@AnnaelleS
Copy link

AnnaelleS commented Oct 1, 2019 •
edited
Loading

@vinitshahdeo
PR #8 opened and ready to be reviewed! :)

@vinitshahdeo vinitshahdeo added the enhancement New feature or request label Oct 1, 2019
@vinitshahdeo vinitshahdeo added the up-for-grabs Solve the issue and raise your first PR label Oct 4, 2019
@Aravind22
Copy link

Aravind22 commented Oct 10, 2019 •
edited
Loading

Is this still open? Is it ok if I give it a go?

@vinitshahdeo
Copy link
Owner Author

@Aravind22 Yeah sure! Please go ahead.

@Aravind22
Copy link

@vinitshahdeo Please check the PR

@deepanshsachdeva
Copy link

@vinitshahdeo PR given. Please check.

@vinitshahdeo
Copy link
Owner Author

@deepanshsachdeva Thanks, will review it soon.

@sarulathadurai
Copy link

is it still open can I contribute

@agarwalaman263 agarwalaman263 mentioned this issue Oct 31, 2020
Open
@JeevaSaravanan
Copy link

@vinitshahdeo Please check this PR.

@tushar-glitch
Copy link

is this issue still open? Can I contribute ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs Solve the issue and raise your first PR
Projects
HacktoberFest 2019
  
To do
Milestone
No milestone
Development

No branches or pull requests
7 participants
@deepanshsachdeva @Aravind22 @vinitshahdeo @AnnaelleS @sarulathadurai @JeevaSaravanan @tushar-glitch