fix(embedded sdk): Remove trailing slash from passed superset domain …

…if there is one (apache#25020)
vinothkumar66 · Aug 25, 2023 · a97a278 · a97a278
1 parent 8754e66
commit a97a278
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/superset-embedded-sdk/package-lock.json b/superset-embedded-sdk/package-lock.json
diff --git a/superset-embedded-sdk/package.json b/superset-embedded-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@superset-ui/embedded-sdk",
-  "version": "0.1.0-alpha.9",
+  "version": "0.1.0-alpha.10",
   "description": "SDK for embedding resources from Superset into your own application",
   "access": "public",
   "keywords": [

diff --git a/superset-embedded-sdk/src/index.ts b/superset-embedded-sdk/src/index.ts
@@ -89,6 +89,10 @@ export async function embedDashboard({
 
   log('embedding');
 
+  if (supersetDomain.endsWith("/")) {
+    supersetDomain = supersetDomain.slice(0, -1);
+  }
+
   function calculateConfig() {
     let configNumber = 0
     if(dashboardUiConfig) {