Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fail if firmware is not readable/usable #369

Open
wavexx opened this issue Oct 3, 2022 · 1 comment
Open

[BUG] Fail if firmware is not readable/usable #369

wavexx opened this issue Oct 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@wavexx
Copy link
Collaborator

wavexx commented Oct 3, 2022

Describe the bug
Running MK404 -f with a broken/missing/non-existing firmware file will still start without complaining if a previous firmware was already loaded.

If -f is provided, it should always require a existing firmware and replace the existing, resulting in a failure.

If -f provides a broken FW, and later MK404 is run without a -f flag, MK404 should stay broken.

The current behavior can lead to the user suspecting the provided FW was actually loaded, even though it didn't for whatever reason.

To Reproduce
The sequence:

M404 -f working_fw
M404 -f file_does_not_exist

should result in the second to fail if the first succeeded.

M404 -f working_fw
M404 -f non_working_fw
M404

should result in both the second and third invocation to fail if the first succeeded.

@wavexx wavexx added the bug Something isn't working label Oct 3, 2022
@vintagepc
Copy link
Owner

I can definitely add a failure if the file is not found.

However, I'm not sure I understand the second request in regards to the third call also failing - "broken" firmware how? If a bad firmware is loaded into flash it will remain there and continue to be broken. Or are you proposing that if a nonexistent file is specified, that the flash space be wiped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants