Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge criteria StronglyValid() and FullyValid() for scion.Base #365

Closed
jcp19 opened this issue Jul 11, 2024 · 0 comments · Fixed by #366
Closed

Merge criteria StronglyValid() and FullyValid() for scion.Base #365

jcp19 opened this issue Jul 11, 2024 · 0 comments · Fixed by #366

Comments

@jcp19
Copy link
Contributor

jcp19 commented Jul 11, 2024

After merging #364, parsePath will guarantee that FullyValid() holds, and thus, the distinction between StronglyValid() and FullyValid() is not necessary anymore. I recommend merging these two properties into one, called Valid(), and to add a comment with the old nomenclatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant