Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--concurrent-downloads command line option is invalid #827

Open
JulianGro opened this issue Oct 20, 2020 · 10 comments · May be fixed by #1428
Open

--concurrent-downloads command line option is invalid #827

JulianGro opened this issue Oct 20, 2020 · 10 comments · May be fixed by #1428
Labels
confirmed The bug has been successfully reproduced. Severity: Low No important functionality is affected stale Issue / PR has not had activity

Comments

@JulianGro
Copy link
Contributor

When running Interface with --concurrent-downloads it returns Unknown option 'concurrent-downloads'.

@ctrlaltdavid
Copy link
Collaborator

What is the exact command line you're using?
Note that some command line options work with either a space or an = between the parameter and the value, and some only work with one or the other. #446

@two-one-five
Copy link
Contributor

I just ran my Interface with that option and it ran... though my stats still show "0/16" downloads indicating my limit is still 16 when I set it to 24, or at least I thought I did.

There are other arguments that use the same method in the code, you can try --avatarURL and see if that works (or not) for you?

@JulianGro
Copy link
Contributor Author

What is the exact command line you're using?
Note that some command line options work with either a space or an = between the parameter and the value, and some only work with one or the other. #446

It doesn't work with --concurrent-downloads=10 or --concurrent-downloads 10

I just ran my Interface with that option and it ran... though my stats still show "0/16" downloads indicating my limit is still 16 when I set it to 24, or at least I thought I did.

There are other arguments that use the same method in the code, you can try --avatarURL and see if that works (or not) for you?

Unknown option 'avatarURL'.

@two-one-five
Copy link
Contributor

So something is wrong with the way those commands are processed on Linux, or in general potentially! There are about 9 references to it in Application.cpp alone.

@JulianGro
Copy link
Contributor Author

JulianGro commented Oct 22, 2020

So apparently all the options that I have tried and didn't work, are not shown in --help.

motofckr9k@motofckr9k-mint-desktop:~/Vircadia/install_logging_improvements$ ./run_interface --help
Usage: /home/motofckr9k/Vircadia/install_logging_improvements/interface/interface [options]
Vircadia

Options:
  -v, --version                            Displays version information.
  -h, --help                               Displays this help.
  --url <value>
  --no-launcher                            Do not execute the launcher
  --no-updater                             Do not show auto-updater
  --checkMinSpec                           Check if machine meets minimum
                                           specifications
  --runServer                              Whether to run the server
  --serverContentPath <serverContentPath>  Where to find server content
  --cache <dir>                            set test cache <dir>
  --scripts <path>                         set scripts <path>
  --allowMultipleInstances                 Allow multiple instances to run
  --tokens <json>                          set response tokens <json>
  --displayName <string>                   set user display name <string>
  --setBookmark <string>                   set bookmark key=value pair
  --defaultScriptsOverride <string>        override defaultsScripts.js
motofckr9k@motofckr9k-mint-desktop:~/Vircadia/install_logging_improvements$ 

Also looks like --concurrent-downloads is using getCmdOption instead of QCommandLineOption which is used in options that work. (Like --get-temp-name on the domain server.

@daleglass
Copy link
Contributor

Looks like command line parsing needs fixing and everything needs to use the same way of doing it

@daleglass daleglass added confirmed The bug has been successfully reproduced. Severity: Low No important functionality is affected labels Oct 24, 2020
@stale
Copy link

stale bot commented Mar 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue / PR has not had activity label Mar 27, 2021
@SilverfishVR
Copy link
Contributor

It works for me on Windows, though the hub is still a bit slow even when set to 64 (on a 200 Mbit/s line)

@daleglass daleglass removed the stale Issue / PR has not had activity label May 8, 2021
@Penguin-Guru Penguin-Guru linked a pull request Oct 25, 2021 that will close this issue
@stale
Copy link

stale bot commented Nov 4, 2021

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Nov 4, 2021
@digisomni digisomni linked a pull request Nov 4, 2021 that will close this issue
@digisomni digisomni removed the stale Issue / PR has not had activity label Nov 4, 2021
@stale
Copy link

stale bot commented May 4, 2022

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The bug has been successfully reproduced. Severity: Low No important functionality is affected stale Issue / PR has not had activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants