Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary k8s object information #12

Open
Jeffwan opened this issue Jan 24, 2021 · 1 comment
Open

Clean up unnecessary k8s object information #12

Jeffwan opened this issue Jan 24, 2021 · 1 comment

Comments

@Jeffwan
Copy link
Contributor

Jeffwan commented Jan 24, 2021

Currently, entire pod detail is printed out.

log.Printf("Received CreatePod request for %+v.\n", pod)

log.Printf("Responding to GetPods: %+v.\n", result)

This makes virtual kubelet fargate provider logs kind of messy. Technically we don't need that many information since these can be retrieved from k8s. Only namespace/name is good enough. I will do some improvements to remove some unnecessary logs.

2021/01/24 14:55:03 Received CreatePod request for &Pod{ObjectMeta:k8s_io_apimachinery_pkg_apis_meta_v1.ObjectMeta{Name:nginx-deployment-6ccfdc75c7-bpphw,GenerateName:nginx-deployment-6ccfdc75c7-,Namespace:default,SelfLink:/api/v1/namespaces/default/pods/nginx-deployment-6ccfdc75c7-bpphw,UID:83326abf-c824-416a-bca7-a524c0fd7979,ResourceVersion:2577384,Generation:0,CreationTimestamp:2021-01-24 14:55:03 -0800 PST,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{app: nginx,pod-template-hash: 6ccfdc75c7,},Annotations:map[string]string{},OwnerReferences:[{apps/v1 ReplicaSet nginx-deployment-6ccfdc75c7 963f3f4a-0d55-46e5-ba3e-77861001bee4 0xc00082788a 0xc00082788b}],Finalizers:[],ClusterName:,Initializers:nil,ManagedFields:[{kube-controller-manager Update v1 2021-01-24 14:55:03 -0800 PST nil}],},Spec:PodSpec{Volumes:[{default-token-grdk6 {nil nil nil nil nil SecretVolumeSource{SecretName:default-token-grdk6,Items:[],DefaultMode:*420,Optional:nil,} nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil}}],Containers:[{nginx nginx:1.7.9 [] []  [{ 0 80 TCP }] [] [{KUBERNETES_SERVICE_PORT_HTTPS 443 nil} {KUBERNETES_PORT tcp://10.96.0.1:443 nil} {KUBERNETES_PORT_443_TCP tcp://10.96.0.1:443 nil} {KUBERNETES_PORT_443_TCP_PROTO tcp nil} {KUBERNETES_PORT_443_TCP_PORT 443 nil} {KUBERNETES_PORT_443_TCP_ADDR 10.96.0.1 nil} {KUBERNETES_SERVICE_HOST 10.96.0.1 nil} {KUBERNETES_SERVICE_PORT 443 nil}] {map[cpu:{{500 -3} {<nil>} 500m DecimalSI} memory:{{1048576000 0} {<nil>}  BinarySI}] map[cpu:{{250 -3} {<nil>} 250m DecimalSI} memory:{{268435456 0} {<nil>}  BinarySI}]} [{default-token-grdk6 true /var/run/secrets/kubernetes.io/serviceaccount  <nil> }] [] nil nil nil /dev/termination-log File IfNotPresent nil false false false}],RestartPolicy:Always,TerminationGracePeriodSeconds:*30,ActiveDeadlineSeconds:nil,DNSPolicy:ClusterFirst,NodeSelector:map[string]string{type: virtual-kubelet,},ServiceAccountName:default,DeprecatedServiceAccount:default,NodeName:virtual-kubelet,HostNetwork:false,HostPID:false,HostIPC:false,SecurityContext:&PodSecurityContext{SELinuxOptions:nil,RunAsUser:nil,RunAsNonRoot:nil,SupplementalGroups:[],FSGroup:nil,RunAsGroup:nil,Sysctls:[],},ImagePullSecrets:[],Hostname:,Subdomain:,Affinity:nil,SchedulerName:default-scheduler,InitContainers:[],AutomountServiceAccountToken:nil,Tolerations:[{virtual-kubelet.io/provider Equal aws NoSchedule <nil>} {node.kubernetes.io/not-ready Exists  NoExecute 0xc000827ca0} {node.kubernetes.io/unreachable Exists  NoExecute 0xc000827cd0}],HostAliases:[],PriorityClassName:,Priority:*0,DNSConfig:nil,ShareProcessNamespace:nil,ReadinessGates:[],RuntimeClassName:nil,EnableServiceLinks:*true,},Status:PodStatus{Phase:Pending,Conditions:[{PodScheduled True 0001-01-01 00:00:00 +0000 UTC 2021-01-24 14:55:03 -0800 PST  }],Message:,Reason:,HostIP:,PodIP:,StartTime:<nil>,ContainerStatuses:[],QOSClass:Burstable,InitContainerStatuses:[],NominatedNodeName:,},}.
2021/01/24 14:55:03 Mapped resource requirements (cpu:512, memory:1000) to task size (cpu:512, memory:1024)
2021/01/24 14:55:04 Responding to GetPodStatus: {Phase:Pending Conditions:[{Type:PodScheduled Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:0001-01-01 00:00:00 +0000 UTC Reason: Message:} {Type:Initialized Status:False LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:0001-01-01 00:00:00 +0000 UTC Reason: Message:} {Type:Ready Status:False LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:0001-01-01 00:00:00 +0000 UTC Reason: Message:}] Message: Reason: NominatedNodeName: HostIP: PodIP: StartTime:2021-01-24 22:55:04 +0000 UTC InitContainerStatuses:[] ContainerStatuses:[{Name:nginx State:{Waiting:&ContainerStateWaiting{Reason:,Message:,} Running:nil Terminated:nil} LastTerminationState:{Waiting:nil Running:nil Terminated:nil} Ready:false RestartCount:0 Image:nginx:1.7.9 ImageID: ContainerID:}] QOSClass:BestEffort}.
2021/01/24 14:55:05 Responding to GetPod: &Pod{ObjectMeta:k8s_io_apimachinery_pkg_apis_meta_v1.ObjectMeta{Name:nginx-deployment-6ccfdc75c7-bpphw,GenerateName:,Namespace:default,SelfLink:,UID:83326abf-c824-416a-bca7-a524c0fd7979,ResourceVersion:,Generation:0,CreationTimestamp:0001-01-01 00:00:00 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[],Finalizers:[],ClusterName:,Initializers:nil,ManagedFields:[],},Spec:PodSpec{Volumes:[],Containers:[{nginx nginx:1.7.9 [] []  [] [] [{KUBERNETES_SERVICE_PORT_HTTPS 443 nil} {KUBERNETES_PORT tcp://10.96.0.1:443 nil} {KUBERNETES_PORT_443_TCP tcp://10.96.0.1:443 nil} {KUBERNETES_PORT_443_TCP_PROTO tcp nil} {KUBERNETES_PORT_443_TCP_PORT 443 nil} {KUBERNETES_PORT_443_TCP_ADDR 10.96.0.1 nil} {KUBERNETES_SERVICE_HOST 10.96.0.1 nil} {KUBERNETES_SERVICE_PORT 443 nil}] {map[cpu:{{512 0} {<nil>} 512 DecimalSI} memory:{{1048576000 0} {<nil>}  BinarySI}] map[cpu:{{512 0} {<nil>} 512 DecimalSI} memory:{{268435456 0} {<nil>}  BinarySI}]} [] [] nil nil nil    nil false false false}],RestartPolicy:,TerminationGracePeriodSeconds:nil,ActiveDeadlineSeconds:nil,DNSPolicy:,NodeSelector:map[string]string{},ServiceAccountName:,DeprecatedServiceAccount:,NodeName:virtual-kubelet,HostNetwork:false,HostPID:false,HostIPC:false,SecurityContext:nil,ImagePullSecrets:[],Hostname:,Subdomain:,Affinity:nil,SchedulerName:,InitContainers:[],AutomountServiceAccountToken:nil,Tolerations:[],HostAliases:[],PriorityClassName:,Priority:nil,DNSConfig:nil,ShareProcessNamespace:nil,ReadinessGates:[],RuntimeClassName:nil,EnableServiceLinks:nil,},Status:PodStatus{Phase:Pending,Conditions:[{PodScheduled True 0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC  } {Initialized False 0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC  } {Ready False 0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC  }],Message:,Reason:,HostIP:,PodIP:,StartTime:2021-01-24 22:55:04 +0000 UTC,ContainerStatuses:[{nginx {ContainerStateWaiting{Reason:,Message:,} nil nil} {nil nil nil} false 0 nginx:1.7.9  }],QOSClass:BestEffort,InitContainerStatuses:[],NominatedNodeName:,},}.

image

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 24, 2021

/assign @Jeffwan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant