Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACI Provider does not handle empty string secrets well #175

Open
fishman opened this issue Nov 22, 2021 · 1 comment
Open

ACI Provider does not handle empty string secrets well #175

fishman opened this issue Nov 22, 2021 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed investigate need investigation

Comments

@fishman
Copy link

fishman commented Nov 22, 2021

Environment summary

Provider (e.g. ACI, AWS Fargate, Hyper)
ACI

Version (e.g. 0.1, 0.2-beta)
Master

K8s Master Info (e.g. AKS, ACS, Bare Metal, EKS)
AKS

Install Method (e.g. Helm Chart, )
Helm Chart

###Issue Details

When I create a gitlab ci runner with an empty variable in the secrets it causes the following error

Warning ProviderCreateFailed 44s (x17 over 11m) virtual-node-aci-linux/pod-controller api call to https://management.azure.com/subscriptions//resourceGroups//providers/Microsoft.ContainerInstance/containerGroups/gitlab-managed-apps-gitlab-runner-gitlab-runner-59b4fd586d-gbtdb?api-version=2018-10-01: got HTTP response status code 400 error code "SecretValueNotSpecified": The value of secret 'runner-token' is not specified in volume 'init-runner-secrets'.

Repo Steps

In the below output you can see how the secret is stored in kubernetes

apiVersion: v1
data:
  runner-registration-token: somebase64==
  runner-token: ""
kind: Secret
metadata:
  annotations:
    meta.helm.sh/release-name: gitlab-runner
    meta.helm.sh/release-namespace: gitlab-managed-apps
  labels:
    app: gitlab-runner-gitlab-runner
    app.kubernetes.io/managed-by: Helm
  name: gitlab-runner-gitlab-runner
type: Opaque
@fishman
Copy link
Author

fishman commented Nov 22, 2021

If the secret is an empty string it should be accessible as such. Instead it's treated as unset.

@ryanzhang-oss ryanzhang-oss added help wanted Extra attention is needed investigate need investigation labels Feb 19, 2022
@helayoty helayoty added the good first issue Good for newcomers label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed investigate need investigation
Projects
None yet
Development

No branches or pull requests

3 participants