Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] CARTO: Order keys for the request cache #8637

Closed
1 of 7 tasks
padawannn opened this issue Mar 12, 2024 · 1 comment · Fixed by #8638
Closed
1 of 7 tasks

[Bug] CARTO: Order keys for the request cache #8637

padawannn opened this issue Mar 12, 2024 · 1 comment · Fixed by #8638
Assignees
@donmccurdy
Labels
bug

Comments

@padawannn
Copy link
Collaborator

Description

We should order the keys from parameters and customHeaders before caching

deck.gl/modules/carto/src/api/request-with-parameters.ts

Line 26 in 401e7a6

const key = JSON.stringify({baseUrl, parameters, customHeaders});

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

No response

Steps to Reproduce

Load any CartoLayer

Environment

  • Framework version: N/A
  • Browser: N/A
  • OS: N/A

Logs

No response
@padawannn padawannn added the bug label Mar 12, 2024
@donmccurdy
Copy link
Collaborator

donmccurdy commented Mar 12, 2024 •
edited
Loading

I can work on this.

EDIT: Opened #8638.

@donmccurdy donmccurdy mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donmccurdy donmccurdy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(carto): Sort params in request cache key. visgl/deck.gl
3 participants
@felixpalmer @donmccurdy @padawannn