From 128df8730b7e1549e530a108192e7bae0699f199 Mon Sep 17 00:00:00 2001 From: Eng Zer Jun Date: Fri, 10 May 2024 01:57:47 +0800 Subject: [PATCH] fix(advanced-marker): remove content element in cleanup (#351) Signed-off-by: Eng Zer Jun --- src/components/advanced-marker.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/advanced-marker.tsx b/src/components/advanced-marker.tsx index 92fdfa8..a21a878 100644 --- a/src/components/advanced-marker.tsx +++ b/src/components/advanced-marker.tsx @@ -107,8 +107,9 @@ function useAdvancedMarker(props: AdvancedMarkerProps) { setMarker(newMarker); // create the container for marker content if there are children + let contentElement: HTMLDivElement | null = null; if (numChildren > 0) { - const contentElement = document.createElement('div'); + contentElement = document.createElement('div'); newMarker.content = contentElement; setContentContainer(contentElement); @@ -116,6 +117,7 @@ function useAdvancedMarker(props: AdvancedMarkerProps) { return () => { newMarker.map = null; + contentElement?.remove(); setMarker(null); setContentContainer(null); };