-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shouldfocus related to #253 #254
Conversation
Awesome, thanks! I think the Also please check the formatting with prettier ( |
whoops youre right ill fix and resubmit |
just made the changes, should be fine now I think |
Could it also be considered to add InfoWindowOpenOptions as a prop entirely in case the interface changes in the future? |
I don't think that makes a lot of sense, since the open-options have to always be considered separately as you did here. So new options would just cause unexpected behaviour until they are implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for the type it's perfect.
Add option to set shouldFocus