fix: memoize context-values to avoid excessive re-renders #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
force-pushed
the
fix/memoize-context-values
branch
2 times, most recently
from
ea51a9b to
a849cf5
Compare
Add memoization to all context values used internally. Without the memoization, the context value of e.g. the GoogleMapsContext (used to retrieve the map-instance in the `useMap` hook) will register as changed every time the map-component re-renders, causing all children that use the context (for example via the `useMap` hook) to re-render as well. With the memoization in place, these unnecessary renders will no longer happen. fixes visgl#285
usefulthink
force-pushed
the
fix/memoize-context-values
branch
from
a849cf5 to
f77f532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add memoization to all context values used internally. Without the memoization, the context value of e.g. the GoogleMapsContext (used to retrieve the map-instance in the
useMaphook) will register as changed every time the map-component re-renders, causing all children that use the context (for example via theuseMaphook) to re-render as well. With the memoization in place, these unnecessary renders will no longer happen.fixes #285