Skip to content

Commit

Permalink
Simplify and improve
Browse files Browse the repository at this point in the history
The browser version assumes that chrome.storage.local uses an API which is compatible with localStorage; which is not the case. Even though I am using chrome.storage.local for my Chrome extension, I would much prefer to keep debug's variable in localStorage, as I consider chrome.storage.local the 'private space' of my extension.

This change obviates the need to support multiple storage types. But if storage type is important, how about supporting a custom storage facility, including chrome.storage.sync? I.e. the user would provide an object that follows the conventions. Just a thought - I certainly don't see the need at this point though.
  • Loading branch information
EirikBirkeland authored Jul 17, 2017
1 parent a45d4a0 commit da51af8
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ exports.formatArgs = formatArgs;
exports.save = save;
exports.load = load;
exports.useColors = useColors;
exports.storage = 'undefined' != typeof chrome
&& 'undefined' != typeof chrome.storage
? chrome.storage.local
: localstorage();
exports.storage = localstorage();

/**
* Colors.
Expand Down

0 comments on commit da51af8

Please sign in to comment.