-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Node.js 10, remove Node.js 4 #583
Conversation
1 similar comment
Thanks! |
It should be a breaking change, why it is published as semver minor. |
@popomore how is this a breaking change? Node 4 is out of LTS. Using Node 4 is deprecated. Further, this PR doesn't affect the public API. Therefore it doesn't constitute a major bump. |
@qix the package or application use debug on Node 4 is broken after this version published. |
@popomore that's not our problem. Node 4 is out of LTS - this code is updated to use modern ES6 that should work on all LTS versions of Node. This PR isn't what changed that. The codebase already had some of it beforehand. Pin your packages if you're worried about packages breaking because you're using Node versions outside of LTS. We can only delay moving forward for so long. |
this is a BREAKING change even node 4 is out of LTS, it breaks all programs which are still running on node 4 (maybe for some historical problem). Drop support for old version of node should be consider as a major version. |
Let's move this out of this PR and into #603 please. No need to spam the OP here. |
No description provided.