Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to override onGroupClick event handler #246

Closed
tmalatinszki opened this issue Jun 29, 2019 · 1 comment
Closed

Possibility to override onGroupClick event handler #246

tmalatinszki opened this issue Jun 29, 2019 · 1 comment
Assignees
Labels
feedback Waiting for feedback

Comments

@tmalatinszki
Copy link

Hi,

I have exactly the same issue which has been already raised for vis earlier: Nesting _onGroupClick interference with html content

For short: if there is a nested group, and the user wants to create a custom group header with some additional functions the click event handler cannot catch the click itself on the custom header elements, since the default handler is registered for the whole div, and not for the small arrow icon, which manages the visibility of the child groups.

The original solution was to override the default event handler method with a custom one, but I did not find a proper way to do the same in ngx-vis yet. Would it be possible to extend the existing event handling with the nested group related ones to be able to disable the original method, and replace with a custom one based on the needs for a custom group template?

If it is not possible, is there any way to disable the original group header event handler without corrupting the original JS code?

Thanks,
Tamás

@hypery2k
Copy link
Collaborator

is this issue still valid?

@hypery2k hypery2k added the feedback Waiting for feedback label Nov 19, 2019
@hypery2k hypery2k self-assigned this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Waiting for feedback
Projects
None yet
Development

No branches or pull requests

2 participants