New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network change detection using wrong parameter names #403

Open

Stexxen opened this issue May 28, 2020 · 0 comments

Stexxen commented May 28, 2020

The network component is expecting parameter names of visNetworkData and visNetworkOptions
https://github.com/visjs/ngx-vis/blob/develop/components/network/vis-network.directive.ts#L29-L51

But ngOnChanges (after initialisation) only makes changes if the variable names are visData and visOptions, which will never happen. (They've lost the 'network' part of the name)
https://github.com/visjs/ngx-vis/blob/develop/components/network/vis-network.directive.ts#L109-L112

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment