fix(lib): enable inlineDynamicImports for umd and iife (#8126)

vitejs · May 11, 2022 · 272a252 · 272a252
1 parent 5ce7c74
commit 272a252
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -441,7 +441,10 @@ async function doBuild(
         // #764 add `Symbol.toStringTag` when build es module into cjs chunk
         // #1048 add `Symbol.toStringTag` for module default export
         namespaceToStringTag: true,
-        inlineDynamicImports: ssr && typeof input === 'string',
+        inlineDynamicImports:
+          output.format === 'umd' ||
+          output.format === 'iife' ||
+          (ssr && typeof input === 'string'),
         ...output
       }
     }

diff --git a/playground/lib/__tests__/lib.spec.ts b/playground/lib/__tests__/lib.spec.ts
@@ -40,7 +40,7 @@ describe.runIf(isBuild)('build', () => {
       'hello vite'
     )
     const code = fs.readFileSync(
-      path.join(testDir(), 'dist/lib/dynamic-import-message.js'),
+      path.join(testDir(), 'dist/lib/dynamic-import-message.es.js'),
       'utf-8'
     )
     expect(code).not.toMatch('__vitePreload')

diff --git a/playground/lib/vite.dyimport.config.js b/playground/lib/vite.dyimport.config.js
@@ -8,9 +8,9 @@ module.exports = {
   build: {
     lib: {
       entry: path.resolve(__dirname, 'src/main2.js'),
-      formats: ['es'],
+      formats: ['es', 'iife'],
       name: 'message',
-      fileName: () => 'dynamic-import-message.js'
+      fileName: (format) => `dynamic-import-message.${format}.js`
     },
     outDir: 'dist/lib'
   }