chore: leave comments

vitejs · Apr 15, 2024 · b446379 · b446379
1 parent f2bce12
commit b446379
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts
@@ -359,8 +359,8 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
           url = wrapId(resolved.id)
         }
 
+        // make the URL browser-valid
         if (environment.options.injectInvalidationTimestamp) {
-          // make the URL browser-valid
           // mark non-js/css imports with `?import`
           if (isExplicitImportRequired(url)) {
             url = injectQuery(url, 'import')

diff --git a/packages/vite/src/node/server/transformRequest.ts b/packages/vite/src/node/server/transformRequest.ts
@@ -468,9 +468,13 @@ async function handleModuleSoftInvalidation(
   }
 
   let result: TransformResult
+  // No transformation is needed if it's disabled manually
+  // This is primarily for backwards compatible SSR
   if (!environment.options.injectInvalidationTimestamp) {
     result = transformResult
-  } else {
+  }
+  // We need to transform each imports with new timestamps if available
+  else {
     const source = transformResult.code
     const s = new MagicString(source)
     const imports = transformResult.ssr