From b4463798235c2adaf6522cf9265c7fb389b26a7f Mon Sep 17 00:00:00 2001 From: Vladimir Sheremet Date: Mon, 15 Apr 2024 15:44:03 +0200 Subject: [PATCH] chore: leave comments --- packages/vite/src/node/plugins/importAnalysis.ts | 2 +- packages/vite/src/node/server/transformRequest.ts | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts index ece0cbc267c3ee..ca790e2ff3bcf9 100644 --- a/packages/vite/src/node/plugins/importAnalysis.ts +++ b/packages/vite/src/node/plugins/importAnalysis.ts @@ -359,8 +359,8 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin { url = wrapId(resolved.id) } + // make the URL browser-valid if (environment.options.injectInvalidationTimestamp) { - // make the URL browser-valid // mark non-js/css imports with `?import` if (isExplicitImportRequired(url)) { url = injectQuery(url, 'import') diff --git a/packages/vite/src/node/server/transformRequest.ts b/packages/vite/src/node/server/transformRequest.ts index 9796cd9e417883..79633fb5f21adb 100644 --- a/packages/vite/src/node/server/transformRequest.ts +++ b/packages/vite/src/node/server/transformRequest.ts @@ -468,9 +468,13 @@ async function handleModuleSoftInvalidation( } let result: TransformResult + // No transformation is needed if it's disabled manually + // This is primarily for backwards compatible SSR if (!environment.options.injectInvalidationTimestamp) { result = transformResult - } else { + } + // We need to transform each imports with new timestamps if available + else { const source = transformResult.code const s = new MagicString(source) const imports = transformResult.ssr