fix(plugin-react): duplicate __self prop and __source prop (#9387)

vitejs · Aug 29, 2022 · c89de3a · c89de3a
1 parent af599ce
commit c89de3a
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 8 deletions.
diff --git a/packages/plugin-react/src/jsx-runtime/babel-restore-jsx.spec.ts b/packages/plugin-react/src/jsx-runtime/babel-restore-jsx.spec.ts
@@ -115,4 +115,18 @@ describe('babel-restore-jsx', () => {
       `"React.createElement(aaa);"`
     )
   })
+
+  it('should not handle contains __self prop', () => {
+    expect(
+      jsx('React.createElement(Provider, { __self: this })')
+    ).toMatchInlineSnapshot('"<Provider />;"')
+  })
+
+  it('should not handle contains __source prop', () => {
+    expect(
+      jsx(
+        'React.createElement(Provider, { __source: { fileName: _jsxFileName, lineNumber: 133 }})'
+      )
+    ).toMatchInlineSnapshot('"<Provider />;"')
+  })
 })
diff --git a/packages/plugin-react/src/jsx-runtime/babel-restore-jsx.ts b/packages/plugin-react/src/jsx-runtime/babel-restore-jsx.ts
@@ -126,14 +126,20 @@ export default function (
     if (!isPlainObjectExpression(node)) {
       return null
     }
-    return node.properties.map((prop: any) =>
-      t.isObjectProperty(prop)
-        ? t.jsxAttribute(
-            getJSXIdentifier(prop.key)!,
-            getJSXAttributeValue(prop.value)
-          )
-        : t.jsxSpreadAttribute(prop.argument)
-    )
+    return node.properties
+      .map((prop: any) =>
+        t.isObjectProperty(prop)
+          ? t.jsxAttribute(
+              getJSXIdentifier(prop.key)!,
+              getJSXAttributeValue(prop.value)
+            )
+          : t.jsxSpreadAttribute(prop.argument)
+      )
+      .filter((prop: any) =>
+        t.isJSXIdentifier(prop.name)
+          ? prop.name.name !== '__self' && prop.name.name !== '__source'
+          : true
+      )
   }
 
   function getJSXChild(node: any) {