Replies: 21 comments 40 replies
-
|
My biggest wish-list item for Vite 3 would be to purge absolute URLs from built apps and make everything relative. Most saliently, those absolute (or root-relative, to be precise) URLs are used with the (I opened #2009, and started working on a PR, but it touched parts of the codebase I was unfamiliar with so I put it on hold until I could devote more time to it.) Without this change, Vite apps aren't portable — they only work if you know the basepath at build time. There are lots of situations where that's not true — off the top of my head:
More discussion about these cases here: sveltejs/kit#595. |
Beta Was this translation helpful? Give feedback.
-
|
Initial implementation at #7644. The wish is quite timely, as it looks like we may need to redefine Vite's modern target to browsers that support |
Beta Was this translation helpful? Give feedback.
-
|
Similar to how Rollup exposes a renderDynamicImport hook, could we imagine a system in Vite that gives users (or wrapping apps) control over how specifiers get rendered? I think it could be conceptually similar to I think a mirror API would also be required. It would give plugins (and consequently apps) the ability to translate dev-time http paths back to local paths. This might involve stripping the sentinel prefix or decoding plugin-controlled virtual paths (ie: |
Beta Was this translation helpful? Give feedback.
-
|
@patak-dev On the topic of |
Beta Was this translation helpful? Give feedback.
-
|
Support |
Beta Was this translation helpful? Give feedback.
-
|
I added an issue mentioning some rough edges we've encountered assuming there's an |
Beta Was this translation helpful? Give feedback.
-
|
Dose vite support use full url of script, link, img... etc in development mode? If vite does not support this, I hope it could do that. It is very useful for micro-frontend development. |
Beta Was this translation helpful? Give feedback.
-
|
Maybe a good time to find a maintained replacement for node-http-proxy, that supports proxy with http/2 ? See #4184. Http/2 is key for dev server speed, and developer experience is currently downgraded to http 1 just in the case proxy is used (quite frequently I suspect to bypass api CORS on local host development). |
Beta Was this translation helpful? Give feedback.
-
|
Browser only support HTTP2 with TLS 😂 |
Beta Was this translation helpful? Give feedback.
-
|
@benatshippabo circling back to this. http2-proxy doesn't seem to be in active development (last release was a year ago). There seems to be a plugin using it available https://github.com/williamyorkl/vite-plugin-proxy-middleware. Have you try using it? If http2-proxy can be used by a userland plugin it looks safer to avoid the dependency in core at this point (maybe we could document this plugin or another one that the community could create later). @pikax maybe this plugin could be useful for you? If you try it out, please let us know how it works. About the fastify plugin, that also seems like something you would use in userland (together with vite in middleware mode), no? Your idea of implementing the proxy in core by stripping the headers could be interesting if the complexity is really as low as you describe. If you would like to try something like this, we could discuss checking the implementation in a PR. If that isn't the case, I think we could leave this feature for v4 to be implemented in Core once better-maintained libs are available, and promote in the meantime the creation of a middleware plugins in user land during the v3 era. |
Beta Was this translation helpful? Give feedback.
-
Yes, my team has been using our custom http2 proxying middleware for a few months now and it works just fine.
Correct, my vision is that we can reference it if we ever needed to implement our own http2 proxying.
Yes, hopefully it is that simple |
Beta Was this translation helpful? Give feedback.
-
|
Sadly that plugin is broken now |
Beta Was this translation helpful? Give feedback.
-
|
Another plugin based on http2-proxy that works with Vite 5 |
Beta Was this translation helpful? Give feedback.
-
|
I have created a proposal of changing |
Beta Was this translation helpful? Give feedback.
-
|
This is a minor thing (that I haven't bothered to make an issue for because it'd be a breaking change), but it'd be wonderful if the |
Beta Was this translation helpful? Give feedback.
-
|
It would be fantastic if we could clear some tech debt by allowing both http2 and proxying at the same time: vite/packages/vite/src/node/http.ts Lines 101 to 104 in d7540c8 Falling back to http1 was only meant as a temporary solution #484 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Yep, same as my comment above 😉. |
Beta Was this translation helpful? Give feedback.
-
|
is there a plan to publish vite as esm? 😉 some background: module: "nodenext" was introduced in ts v4.5, but has been experimental for some reasons, but it's very likely to be stable in v4.7. TypeScript 4.7 adds this functionality with two new module settings: node12 and nodenext. |
Beta Was this translation helpful? Give feedback.
-
|
I'm very willing to help if you want. 😄 |
Beta Was this translation helpful? Give feedback.
-
|
We had briefly talked about this in the last team meeting. The concern is that it would double the package size where half would only always be used. Plus some parts of the code relies on |
Beta Was this translation helpful? Give feedback.
-
|
The Vite docs mention the following :
I am very unfamiliar with the codebase, but is this still something in consideration ? |
Beta Was this translation helpful? Give feedback.
-
|
There hasn't been talks about it except #4921 because Vite currently contains a collection a Rollup plugins to handle dev and build. The plugin format is not quite compatible with esbuild, but if the linked discussion is to be realized (as prebundling uses esbuild), it could make the change easier. Right now it's mostly speculative though. |
Beta Was this translation helpful? Give feedback.
-
|
As another idea: for vite react plugin, replace babel plugins by swc or native esbuild plugins to gain speed. |
Beta Was this translation helpful? Give feedback.
-
|
You can check out https://github.com/iheyunfei/vite-on-swc. It could be supported directly in |
Beta Was this translation helpful? Give feedback.
-
|
Do we all agree that SSR dependencies should always be externalized? (With the exception of dependencies that the user added to CC @benmccann. |
Beta Was this translation helpful? Give feedback.
-
|
I sent a change in #8033 to do this. It could theoretically be in a 2.9 release as it shouldn't be a breaking change. Thanks to @ygj6 for figuring out the hard part and making it work! |
Beta Was this translation helpful? Give feedback.
-
|
Maybe a plugin hook to pre-render |
Beta Was this translation helpful? Give feedback.
-
|
Use a linkedom instance as a fast virtual DOM for SSR and plugins Currently, the transformIndexHtml hook operates on a string representation of the DOM. Plugin authors can provide a set of Instead, Vite could parse the static |
Beta Was this translation helpful? Give feedback.
-
|
I have built a separate hook in https://nostalgie.dev to allow plugins to mutate the DOM during server rendering. The interface looks like this: export interface ServerPlugin<TPluginState = unknown> {
// snip \\
/**
* Called with an [linkedom](https://npm.im/linkedom) `Document` instance, giving plugins
* the ability to manipulate the document prior to serializing and serving it.
*
* Plugins might use this to set the document's title, change element attributes or perform
* any other DOM manipulation that should be reflected in the actual HTML served.
*/
renderHtml?(ctx: ServerPluginContext<TPluginState>, document: Document): void;
}As a result, the injection of the export function vitePlugin(): ServerPlugin {
return {
name: 'vite-plugin',
renderHtml(ctx, document) {
const reactRefreshEl = document.createElement('script');
reactRefreshEl.appendChild(
document.createTextNode(
`
import RefreshRuntime from "http://localhost:3000/@react-refresh"
RefreshRuntime.injectIntoGlobalHook(window)
window.$RefreshReg$ = () => {}
window.$RefreshSig$ = () => (type) => type
window.__vite_plugin_react_preamble_installed__ = true
`.trim()
)
);
reactRefreshEl.setAttribute('type', 'module');
document.head.appendChild(reactRefreshEl);
const viteClientEl = document.createElement('script');
viteClientEl.setAttribute('src', '/@vite/client');
viteClientEl.setAttribute('type', 'module');
document.head.appendChild(viteClientEl);
},
};
}One area where this is particularly cool is that it gives an opportunity to use the same logic on the client and server for DOM querying and manipulation instead of fracturing this between text manipulation and the full browser DOM. |
Beta Was this translation helpful? Give feedback.
-
|
@benmccann I noticed that you gave this a 👎🏼. Can you share some context on why you think this would be a poor fit for Vite? |
Beta Was this translation helpful? Give feedback.
-
|
I wouldn't want to always parse the DOM as it seems like a waste of effort in cases you don't need the feature. Also, |
Beta Was this translation helpful? Give feedback.
-
|
I suggest this API since it seems we're already parsing and traversing the HTML in vite/packages/vite/src/node/plugins/html.ts Line 256 in d49e3fb traverseHtml seems to parse and traverse its AST: vite/packages/vite/src/node/plugins/html.ts Lines 138 to 155 in d49e3fb I suspect that the big draw-back of using something like |
Beta Was this translation helpful? Give feedback.
-
|
A very minor breaking change to be discussed:
|
Beta Was this translation helpful? Give feedback.
-
|
Dynamic imports with aliases are not working still: import(`@/assets/${props.type}.svg`)
👆 |
Beta Was this translation helpful? Give feedback.
-
|
It should be supported since #7756 for Vite 3. If not can you open an issue with a repro? Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
I wish vite can natively supports node app development such as express and fastify. |
Beta Was this translation helpful? Give feedback.
-
|
You can already do that using |
Beta Was this translation helpful? Give feedback.
-
Why to change the default strategy from pre-scans user code to delaying? Here is my test reporter.From my test, pre-scan will optimize 9 deps. Vite 3 with
|
Beta Was this translation helpful? Give feedback.
-
|
@sxzz could you provide the repro you used for the video above? |
Beta Was this translation helpful? Give feedback.
-
|
Wait a moment, preparing... |
Beta Was this translation helpful? Give feedback.
-
|
I created a new repo, https://github.com/sxzz/vite3-optimize-deps If you disable
|
Beta Was this translation helpful? Give feedback.
-
|
I found the problem, each of these new deps is messing the previous optimized chunks so a reload is needed, and it looks like it isn't about shared code but about the esbuild helpers. The ideal would be to have an option to make the helpers external as proposed here evanw/esbuild#1230. But I'll check how we can at least pre-generate them as a single chunk to avoid the reloads.
What do you mean by this? In vite 2 it was correctly ignored, seems that it is being optimized in vite 3 in your repro and that is a bug to me. Could you explain why you think this needs to be optimized? |
Beta Was this translation helpful? Give feedback.
-
I'm meaning this strategy is bad for me. I think it should be pre-optimized. |
Beta Was this translation helpful? Give feedback.
-
|
Evan You， 头像好帅 |
Beta Was this translation helpful? Give feedback.
-
|
I just switched our Is this expected? And if it is, isn't this a slight regression? I guess it's worth it if you had troubles when dev env behaved differently from the prod in the past, but we have never experienced anything like that. |
Beta Was this translation helpful? Give feedback.
-
|
If I'm not mistaken, I've heard of libraries bundled with esbuild doesn't treeshake well, though I don't know the specifics of what causes it. This relates to pre-bundling as each deps would be mini esbuild-bundled libraries which causes the issue. It's something we should definitely check from time to time, and maybe improve esbuild along the way (or we can do some tricks in Vite) |
Beta Was this translation helpful? Give feedback.
-
|
Hello! I see an issue, not working vite app, but no problem react app. This is react-speech-recognition |
Beta Was this translation helpful? Give feedback.
-
|
Please create a minimal reproduction and a bug report in the repo. Thanks! |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
The reproduction isn't going to be tracked here. You need to create a new issue following the issue form at https://github.com/vitejs/vite/issues/new/choose |
Beta Was this translation helpful? Give feedback.
-
|
thanks! |
Beta Was this translation helpful? Give feedback.
and others
-
After Node v12 EOL (end of April), we're starting the beta process for Vite v3. You can check the current PRs queued up for 3.0 in the v3 milestone.
The major bump is mainly driven by dropping Node v12. We will take the opportunity to remove deprecated APIs. A yearly cadence for Vite majors should allow us to regularly clean up the codebase. And there should be enough time for the Ecosystem to plan and move out of these APIs.
On top of this, we will have the usual fixes, perf improvements, and features we have for each minor. We could include a redesign for the CLI, and it would also be good to use a new theme for the docs with dark theme support.
There are some interesting proposals that would be great if we could push forward (although they could be also be added in future 3.x minors):
For most users, upgrading to Vite v3 should be similar to the process of doing so for a minor. But we could take the opportunity to review defaults or design choices if there is a straightforward path for upgrading and the ecosystem would benefit from these changes.
@benmccann already started to put some of these ideas on the table:
fixStacktracedefault tofalse#7528If you have feedback about Vite 3, especially regarding breaking changes that we will not be able to do in future minors, let's discuss this here or create an issue and link it to this discussion.
Beta Was this translation helpful? Give feedback.
All reactions