Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): support trailing comma #10211

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix(worker): support trailing comma #10211

merged 1 commit into from
Sep 23, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 23, 2022

Description

Fix #10206

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: web workers labels Sep 23, 2022
@bluwy bluwy mentioned this pull request Sep 23, 2022
Closed
9 tasks
@patak-dev patak-dev merged commit 0542e7c into main Sep 23, 2022
@patak-dev patak-dev deleted the worker-trailing-comma branch September 23, 2022 07:10
@patak-dev
Copy link
Member

I just created the v3.1 branch in case we want to backport this bug fix and release it as a patch.

@ydcjeff ydcjeff mentioned this pull request Sep 24, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing comma in new Worker() breaks options parsing
2 participants
@bluwy @patak-dev