Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite server doesn't handle a URL where there is a '.' after the port #10343

Closed
7 tasks done
dylanplural opened this issue Oct 4, 2022 · 1 comment
Closed
7 tasks done
Labels
duplicate This issue or pull request already exists

Comments

@dylanplural
Copy link

Describe the bug

In dev mode I have vite running at localhost:5173

I had a react-router running with a dynamic url

navigate(`/users/${encodeURIComponent(user.email)}`) // react-router

This works fine. However F5 will lead to a 404. Removing the '.' from the user's email will make the error go away.

Reproduction

Install react-router

System Info

System:
    OS: Linux 5.10 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (8) x64 AMD Ryzen 9 3900XT 12-Core Processor
    Memory: 11.02 GB / 15.63 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash

  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 3.2.3 - ~/.nvm/versions/node/v16.14.2/bin/yarn
    npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm

Used Package Manager

yarn

Logs

VITE v3.1.0 ready in 300 ms

➜ Local: http://localhost:5173/
➜ Network: use --host to expose
vite:spa-fallback Not rewriting GET /comps/email.domain because the path includes a dot (.) character. +0ms
vite:time 2.54ms /comps/email.domain +0ms

Validations

@sapphi-red
Copy link
Member

Duplicate of #2415

@sapphi-red sapphi-red marked this as a duplicate of #2415 Oct 5, 2022
@sapphi-red sapphi-red added duplicate This issue or pull request already exists and removed pending triage labels Oct 5, 2022
@sapphi-red sapphi-red closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants