Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript update #11201

Closed
4 tasks done
dominikg opened this issue Dec 5, 2022 · 1 comment
Closed
4 tasks done

typescript update #11201

dominikg opened this issue Dec 5, 2022 · 1 comment
Labels
enhancement New feature or request p1-chore Doesn't change code behavior (priority)

Comments

@dominikg
Copy link
Contributor

dominikg commented Dec 5, 2022

Description

  • typescript is a mix of 4.6 and 4.8 in pnpm-lock.yaml
  • renovate does not update it:
    "typescript",
  • 4.9 has been out for a bit

Suggested solution

update to 4.9 and consolidate use of typescript to a single version

Alternative

keep it as is

Additional context

i suppose this is mostly relevant for building types, and indeed running pnpm update -r typescript@^4.93 and pnpm build results in errors.

Updating could enable removing some expect-error annotations and cool new things like satisfies

Validations

@bluwy bluwy added enhancement New feature or request p1-chore Doesn't change code behavior (priority) and removed enhancement: pending triage labels Dec 6, 2022
@dominikg
Copy link
Contributor Author

dominikg commented Dec 7, 2022

fixed in #11229

@dominikg dominikg closed this as completed Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

No branches or pull requests

2 participants