Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite build warnings should be on a new line #11207

Closed
7 tasks done
dherault opened this issue Dec 5, 2022 · 2 comments
Closed
7 tasks done

Vite build warnings should be on a new line #11207

dherault opened this issue Dec 5, 2022 · 2 comments
Assignees
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@dherault
Copy link

dherault commented Dec 5, 2022

Describe the bug

Here's what I witnessed:
image

As you can see the eval warning is placed right after the build output. It should be on a new line.

Reproduction

https://stackblitz.com/edit/vitejs-vite-ourja9?file=main.js

Steps to reproduce

  • Use eval in a project
  • Build it with vite build --watch

System Info

System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 22.16 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.6.0 - ~/.nvm/versions/node/v18.6.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.6.0/bin/yarn
    npm: 8.13.2 - ~/.nvm/versions/node/v18.6.0/bin/npm
  npmPackages:
    @vitejs/plugin-react: ^2.2.0 => 2.2.0 
    vite: ^3.2.5 => 3.2.5 

Used Package Manager

npm

Logs

No response

Validations

@dherault
Copy link
Author

dherault commented Dec 5, 2022

Feel free to close as wontfix if this does not bother you.

@ArnaudBarre ArnaudBarre self-assigned this Dec 9, 2022
@ArnaudBarre ArnaudBarre added p2-nice-to-have Not breaking anything but nice to have (priority) and removed pending triage labels Dec 9, 2022
@patak-dev
Copy link
Member

Fixed by #12924

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants