fix(css): fix stale css when reloading with hmr disabled (#10270) #11506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10270.
In the non-hmr code path, when invalidating a module, it wasn't invalidating the importers. This meant that CSS dynamically generated based on a module's contents (e.g., what tailwind does) would not regenerate when refreshing a page.
The HMR code path already invalidated importers, which is why the bug didn't exist with HMR enabled. This change makes the invalidation consistent between HMR and non-HMR.
The changes are quite minimal -- it's just merging some of the logic from the
invalidate
function (in hmr.ts) into theinvalidateModule
function (in moduleGraph.ts) and updating the call site.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).