Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): add preprocess to sveltejs template #11600

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

ghostdevv
Copy link
Contributor

Description

Preprocessing is currently missing from create-vite's template-svelte. Dominik mentioned to me that it was removed to make the template more light weight as it used to be an extra dependency. Since we now have vite preprocess it would be great to have this back out of the box.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ghostdevv ghostdevv changed the title feat(create-vite): add preprocess to js template feat(create-vite): add preprocess to sveltejs template Jan 5, 2023
@bluwy bluwy merged commit 529b0a6 into vitejs:main Jan 5, 2023
@bluwy
Copy link
Member

bluwy commented Jan 5, 2023

Thanks! If you'd like, you can also send the same changes to https://github.com/bluwy/create-vite-extra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants