Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview): improve error when build output missing #12096

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 17, 2023

Description

Re-introduce the feature from #10564 that was previously reverted as it broke preview servers that uses configurePreviewServer, even if there's missing build output.

This PR is the same as #10564, except it only errors if no plugins implement configurePreviewServer and if it runs through Vite's CLI. This should help new users who start a simple Vite project.

Additional context

I noticed they are consistently issues time-to-time regarding this behaviour, and maybe it's good to implement a simple one for now.

Extra context: #11579 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 17, 2023
faga295
faga295 previously approved these changes Feb 17, 2023
Copy link

@faga295 faga295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@patak-dev patak-dev merged commit a0702a1 into main Feb 18, 2023
@patak-dev patak-dev deleted the preview-build-error branch February 18, 2023 12:08
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants