feat: don't override build.target if terser is 5.16.0+
#12197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
bluwy
reviewed
Feb 25, 2023
sapphi-red
changed the title
build.targetbuild.target if terser is 5.16.0+
bluwy
approved these changes
Mar 1, 2023
|
Thanks a lot @sapphi-red, I can finally use ES2022 top-level |
|
Looks like the
|
|
@laurentpayot please create a new issue regarding the outdated docs so we can track it and you are welcome to send a pull request 😊 |
laurentpayot
added a commit
to laurentpayot/vite
that referenced
this pull request
Mar 21, 2023
Updated docs after vitejs#12197: `build.target` is overridden to `'es2021'` for installed Terser versions below 5.16.0 only.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
terser now seems to support ES2022 syntaxes.
When this part of code was introduced, terser was lacking support for ES2019+ for a while. But now terser supports new syntax in few month, so I guess we can just drop this condition.
close #12196
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).