perf(resolve): support # in path only for dependencies

[patak-dev]

Description

@sun0day has been investigating tryFsResolve double checks to support paths with #. See:

• test(resolve): cover the codes that parse the fs path contained postfix #12436

We added the checks to resolve the file path without removing the postfix because of dependencies like es5-ext here:

• fix: consider # as a valid dir symbol (fix #4701) #4703

But the use of ? and # never worked in user code and this is something we can control. Requiring users to avoid ? and # in their paths is a fair price to pay to avoid double checks.

This PR formalizes that we only support # in dependencies paths, and removes the double checks in other cases. Note: I only included support for # here, and not ? so the double checks won't be triggered for every dependency.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	✅ success
histoire	❌ failure
iles	✅ success
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	❌ failure
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	❌ failure
vite-plugin-ssr	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success
windicss	✅ success

[patak-dev]

Ecosystem CI looks fine, same fails as in main (SvelteKit latest main is failing rigth now)

[sun0day]

I think we can add some comments before each if branch. The comments tell what fsPath will hit these if conditions. It's helpful for understanding these codes quickly and refactoring them later. And I guess there are still rooms to dedupe resolve logic.

[patak-dev]

I renamed the variable instead of adding a new comment because I think the main comment for tryUnsplitted is enough now.