fix: use nearest pkg to resolved for moduleSideEffects #12628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
added
the
p3-minor-bug
patak-dev
deleted the
fix/use-nearest-pkg-to-resolved-for-moduleSideEffects
branch
|
Thanks a lot for testing these issues @sapphi-red 💚 |
|
A bit late, but it would be nice to add tests for this to prevent future regressions. Thanks for fixing this though! |
This was referenced Apr 7, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@bluwy checked that this is how it works in rollup. And it is also how it already works inside
tryNodeResolve.close #6740
close #7979
What is the purpose of this pull request?