Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): show ssr module loader error stack #12651

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Mar 29, 2023

Description

fix #12631

This pr contains 3 parts:

  1. add the original error stack to the output
  2. propagate the importee info from ssrLoadModule
  3. avoid removing the error's importee info

image

Additional context

Maybe we can combine the errors via the urlStack and emit it only once. It will provide a better DX.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Mar 29, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides looking into the weakmap approach, this lgtm! The try-catch would indent the function (and mess git blame a bit), but it seems to be the simplest and direct approach for now.

@patak-dev patak-dev merged commit 050c0f9 into vitejs:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite eats proper error messages and replaces them with just [vite] Error when evaluating SSR module
3 participants