fix: race condition creation module in graph in transformRequest #13085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potential fix for #13030
Related to #8533
There could be a race condition if on the middle of processing a request, something changes in the environment (user code, optimized dep invalidation) that causes
resolveId
to return two different ids for the same URL.We already had the
module
or theresolve
result, and inloadAndTransform
we were doing a newresolveId
from theurl
after call load. This PR, avoids re-resolving by passing theresolved
result if we already did it before load so we ensure the module node we add to the graph is the one we are currently transforming.What is the purpose of this pull request?