fix: off-by-one bug in HTML whitespace removal #14589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14274 (comment)
startCol
is 1-indexed, whilestartOffset
is 0 indexed. This fix ensuresmagic-string
isn't given a negative start position when checking a specific line.Additional context
Same thing I mentioned on #14274 in that there doesn't seem to be any existing tests for the HTML output, just browser/integration tests, but I'd be happy to add a few if someone could direct me towards what's needed.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).