Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: off-by-one bug in HTML whitespace removal #14589

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

rschristian
Copy link
Contributor

Description

Fixes #14274 (comment)

startCol is 1-indexed, while startOffset is 0 indexed. This fix ensures magic-string isn't given a negative start position when checking a specific line.

Additional context

Same thing I mentioned on #14274 in that there doesn't seem to be any existing tests for the HTML output, just browser/integration tests, but I'd be happy to add a few if someone could direct me towards what's needed.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@rschristian rschristian changed the title fix: Off-by-one bug in HTML whitespace removal fix: off-by-one bug in HTML whitespace removal Oct 12, 2023
@sapphi-red sapphi-red added feat: html p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Oct 12, 2023
@patak-dev patak-dev merged commit f54e6d8 into vitejs:main Oct 12, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants