Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): switch to default Remix template #16203

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

markdalgleish
Copy link
Contributor

@markdalgleish markdalgleish commented Mar 19, 2024

Description

We've just updated create-remix so that our default template is using Vite. Our vite template is now deprecated and will be removed once this PR is shipped. Since we're moving to Vite as the new default, we're not going to have specific templates for Vite anymore and will instead only be calling out when our templates aren't using Vite.

Additional context

Thanks again for including us in create-vite :)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit ea480df into vitejs:main Mar 19, 2024
10 checks passed
@patak-dev
Copy link
Member

Nice! Let us know when would be the best time to cut a create-vite release. If it sounds good to you we'll release it together with Vite 5.2 stable (prob tomorrow or thursday)

@markdalgleish
Copy link
Contributor Author

We're flexible, no rush from our side 🙂

@markdalgleish markdalgleish deleted the remix-template-update branch March 19, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants