Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16135 introduced development server bug #16245

Closed
7 tasks done
ZerdoX-x opened this issue Mar 23, 2024 · 5 comments · Fixed by #16246
Closed
7 tasks done

#16135 introduced development server bug #16245

ZerdoX-x opened this issue Mar 23, 2024 · 5 comments · Fixed by #16246
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release

Comments

@ZerdoX-x
Copy link

ZerdoX-x commented Mar 23, 2024

Describe the bug

vite dev boots up the server, but it doesn't respond to several file requests, causing the page to infinitely load

Affected vite plugin (in my case): @inlang/paraglide-js-adapter-sveltekit

@knd775 probably has other affected plugin (as paraglide tool it not very popular), but we don't know which one yet.

I can confirm that #16135 introduced a bug. I have built vite locally and all commits after 5.2.0-beta.0 and before #15135 work fine.

More info: #16135 (comment) 1220740873273475162 (discord thread)

UPD0: I have tried to reproduce the issue without sveltekit, no luck.
UPD1: Sveltekit issue sveltejs/kit#12020

Reproduction

https://git.sr.ht/~zerdox/paraglide-js-adapter-sveltekit_incompatibility_vite-5.2.0-beta.1

Steps to reproduce

  1. pnpm i
  2. pnpm run dev or pnpm vite dev

Probably could be reproduced with other package managers too.

System Info

System:
    OS: Linux 6.6 Gentoo Linux
    CPU: (8) arm64 unknown
    Memory: 6.10 GB / 15.27 GB
    Container: Yes
    Shell: 5.2.26 - /bin/bash
  Binaries:
    Node: 20.11.0 - /run/user/1000/fnm_multishells/9198_1711199923378/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 10.2.4 - /run/user/1000/fnm_multishells/9198_1711199923378/bin/npm
    pnpm: 8.15.4 - ~/.local/share/pnpm/pnpm
    bun: 1.0.30 - ~/.local/share/bun/bin/bun
  Browsers:
    Chromium: 116.0.5845.187
  npmPackages:
    vite: 5.2.4 => 5.2.4

Used Package Manager

pnpm

Logs

No response

Validations

@ZerdoX-x ZerdoX-x changed the title #16135 introduced issue with dev server #16135 introduced development server bug Mar 23, 2024
@knd775
Copy link

knd775 commented Mar 23, 2024

I won't be back at a computer for a while to gather more info, but I am not using paraglide.

There's also an issue on the sveltekit repo for this sveltejs/kit#12020

@fredguest
Copy link

Came here to post the same bug, thanks for detailing the issue.

@arxpoetica
Copy link

I have a repro of the bug, pre-and-post v5.1.6 Vite:

https://github.com/arxpoetica/inlang-sveltekit-vite-bug

I tried to reproduce this on StackBlitz for easier debugging, but that was creating issues on its own.

@patak-dev
Copy link
Member

Thanks for creating the issue, and thanks for the repro @arxpoetica 🙏🏼
This should be fixed by #16246

I'll run ecosystem-ci on it, and let you try it out. I'll merge it and do a release tomorrow.

@sapphi-red sapphi-red added p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release labels Mar 24, 2024
@arxpoetica
Copy link

Can confirm this fixed it, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants