fix(css): ensure sass compiler initialized only once #18128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
changed the title
sapphi-red
added
p3-minor-bug
sapphi-red
approved these changes
Sep 18, 2024
bluwy
approved these changes
Sep 18, 2024
sapphi-red
pushed a commit
to sapphi-red/vite
that referenced
this pull request
Sep 24, 2024
sapphi-red
added a commit
that referenced
this pull request
Sep 24, 2024
…#18184) Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test I added doesn't fail on main since Vitest probably just exits regardless of hanging resource. However, it can be used to test it manually and this hangs on main: