Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove _onCrawlEnd #18207

Merged
merged 1 commit into from
Sep 27, 2024
Merged

refactor: remove _onCrawlEnd #18207

merged 1 commit into from
Sep 27, 2024

Conversation

sapphi-red
Copy link
Member

Description

Resolved the TODO 😀

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) feat: environment API Vite Environment API labels Sep 27, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this looks so much better :D

@patak-dev patak-dev merged commit bea0272 into vitejs:main Sep 27, 2024
12 checks passed
@sapphi-red sapphi-red deleted the refactor/remove-on-crawl-end branch September 27, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: environment API Vite Environment API p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev