Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): make build-html plugin work with sharedPlugins #18214

Merged

Conversation

sapphi-red
Copy link
Member

Description

When sharedPlugins is enabled, build-html plugin generated the same html multiple times for each environment.

@sapphi-red sapphi-red added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) feat: environment API Vite Environment API labels Sep 27, 2024
Copy link

stackblitz bot commented Sep 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@patak-dev patak-dev merged commit 34041b9 into vitejs:main Sep 27, 2024
12 checks passed
@sapphi-red sapphi-red deleted the fix/build-html-plugin-sharedPlugins branch September 27, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: environment API Vite Environment API feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants