Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test optimized dep as ssr entry #18301

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Oct 8, 2024

Description

In Vite 5, ssrLoadModule("optimized-dep") is failing (initially raised by Tobbe on discord and here is a repro https://github.com/hi-ogawa/reproductions/tree/main/vite-ssr-optimizeDeps-entry), but it looks like this works now. It's fairly an edge case (also has a workaround in Vite 5), but I think it's not bad to have a test.

Copy link

stackblitz bot commented Oct 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review October 8, 2024 06:40
@patak-dev patak-dev merged commit 466f94a into vitejs:main Oct 8, 2024
15 checks passed
@hi-ogawa hi-ogawa deleted the test-ssr-optimized-entry branch October 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants