Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .git to deny list by default #18382

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

patak-dev
Copy link
Member

Description

Even if credentials shouldn't be committed to git, we discussed with others in the team that it makes sense to add .git to the default server deny list.

@patak-dev patak-dev added p2-nice-to-have Not breaking anything but nice to have (priority) feat: dev dev server labels Oct 17, 2024
Copy link

stackblitz bot commented Oct 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added this to the 6.0 milestone Oct 17, 2024
@sapphi-red
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci

This comment was marked as outdated.

@vite-ecosystem-ci
Copy link

@patak-dev patak-dev merged commit 105ca12 into main Oct 18, 2024
23 checks passed
@patak-dev patak-dev deleted the feat/add-dot-git-to-deny-by-default branch October 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: dev dev server p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants