Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): update to svelte 5 #18407

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 21, 2024

Description

I simply ran npx sv@latest migrate svelte-5 and changed the svelte version to ^5.0.3 from ^5.0.0.

Copy link

stackblitz bot commented Oct 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Oct 21, 2024
@bluwy
Copy link
Member

bluwy commented Oct 21, 2024

The import './index.css' import order has implication if nested components also import global css, since the ordering happens on which side-effect import happens first. But sorting it to the bottom shouldn't cause too much issue I think, it was already happening for some templates.

@bluwy
Copy link
Member

bluwy commented Oct 21, 2024

Actually, it seems like it's affecting the React template. For example between index.css and App.css. I think I'd expect index.css to have the higher priority (placed first) in the bundled CSS output. So maybe we should be putting these global CSS top before any imports for consistency 🤔

@sapphi-red
Copy link
Member Author

Ah, that's true.

bluwy
bluwy previously approved these changes Oct 21, 2024
@benmccann
Copy link
Collaborator

I think there's someplace that the CLI invokes npm create svelte if you want to create a SvelteKit app? Can we have it invoke npx sv create instead? There's a pretty good chance that npm create svelte goes away shortly. (I have a PR to do that out for discussion: sveltejs/kit#12850)

Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed that change. This looks good to me now

@sapphi-red sapphi-red merged commit 291830f into vitejs:main Oct 22, 2024
14 checks passed
@sapphi-red sapphi-red deleted the feat/update-to-svelte-5 branch October 23, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat: create-vite create-vite package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants