fix(plugins): noop if config hook returns same config reference #18467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
config()
hook returns the same config given, Vite currently merges it again, causing the config to merge onto itself, causing unintended behaviour likeresolve.conditions
duplicating or other array-based fields.This PR skips the merge if so to prevent unnecessary work, which in most cases shouldn't be a breaking change. Open to discussion though if we think this is nice to have, or we can ignore it for now.
I found this footgun happening in withastro/astro#12287. And searching around, it seems to happen elsewhere: