perf(css): skip style.css extraction if code-split css #18470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we're code-splitting CSS, there's a portion of the code that was still extracting combined CSS chunks to emit the non-codesplit
style.css
chunk, which would always be empty.The extraction was happening from
vite/packages/vite/src/node/plugins/css.ts
Line 887 in bd540d5
However the
chunkCSSMap
is only populatedcssCodeSplit
is disabledvite/packages/vite/src/node/plugins/css.ts
Lines 832 to 838 in bd540d5
This PR updates so that the extracting of combined CSS chunks only happens if
cssCodeSplit
is disabled.