Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's 3 commits in this PR:
e.line
ande.column
to error object when compiler with scss modern api. It's missing by default which makes the file name open-in-editor not have the line/col. (Astro had a test that expected the positional info to exist. I don't think this is a breaking change, but figured nice to fix anyway)e.frame = e.message
to prevent it (mimicking same behaviour as legacy api for now)I think the error messages could be a little better for css preprocessors, but it's a bit subjective so i didn't want to make a too drastic change for now.
Before (legacy)
Before (modern)
After (legacy)
After (modern)