-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use server.perEnvironmentStartEndDuringDev
#18549
fix: use server.perEnvironmentStartEndDuringDev
#18549
Conversation
plugin.perEnvironmentStartEndDuringDev !== true, | ||
config.server.perEnvironmentStartEndDuringDev || | ||
plugin.perEnvironmentStartEndDuringDev === true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was opposite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean conditions are the hardest ones 🤦🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I didn't understand your linked question. I thought we only had this option at the plugin level and not a way to enable it for all plugins. This makes sense to me though.
await this.hookParallel( | ||
'buildEnd', | ||
(plugin) => this._getPluginContext(plugin), | ||
() => [], | ||
(plugin) => | ||
this.environment.name === 'client' || | ||
plugin.perEnvironmentStartEndDuringDev !== true, | ||
config.server.perEnvironmentStartEndDuringDev || | ||
plugin.perEnvironmentStartEndDuringDev === true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can replace both plugin.perEnvironmentStartEndDuringDev === true
with plugin.perEnvironmentStartEndDuringDev
too, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It required expanding hookParallel
's type a bit, but it was possible 👍
Description
server.perEnvironmentStartEndDuringDev
was not used anywhere.refs #18491 (comment)