Dynamic import with type: 'json' causes syntax error on Firefox

[hyunbinseo]

Describe the bug

const module = () => import('./sample.json', { with: { type: 'json' } }); // breaks
const module = () => import('./sample.json', { assert: { type: 'json' } }); // breaks
const module = () => import('./sample.json'); // works

In Firefox 133.0.3 (aarch64)

Uncaught SyntaxError: missing ) after argument list main.js:6:54

Reproduction

https://stackblitz.com/edit/vitejs-vite-rde9qabm?file=src%2Fmain.js

Steps to reproduce

No response

System Info

System:
  OS: Linux 5.0 undefined
  CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Memory: 0 Bytes / 0 Bytes
  Shell: 1.0 - /bin/jsh
Binaries:
  Node: 18.20.3 - /usr/local/bin/node
  Yarn: 1.22.19 - /usr/local/bin/yarn
  npm: 10.2.3 - /usr/local/bin/npm
  pnpm: 8.15.6 - /usr/local/bin/pnpm

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[hi-ogawa]

@JamesParrott Your issue is likely different and that's babel / react plugin issue vitejs/vite-plugin-react#385 It should be fixed (workarounded) in latest react plugin, so please try it after upgrading it.

[hi-ogawa]

Vite doesn't strip off import attributes for dynamic import, so the browsers get errors depending on their support.

vite/packages/vite/src/node/plugins/importAnalysis.ts

Lines 500 to 503 in e1b520c

	// strip import attributes as we can process them ourselves
	if (!isDynamicImport && attributeIndex > -1) {
	str().remove(end + 1, expEnd)
	}

On Firefox, it's a syntax error as it looks like they don't accept it yet https://bugzilla.mozilla.org/show_bug.cgi?id=1736059

On Chrome, the syntax is fine, but Vite is responding text/javascript, so this causes a different error:
https://stackblitz.com/edit/vitejs-vite-8nxtabzl?file=src%2Fmain.js

Failed to load module script: Expected a JSON module script but the server responded with a MIME type of "text/javascript". Strict MIME type checking is enforced for module scripts per HTML spec.

[JamesParrott]

Excellent. Thankyou very much :)