fix(plugin): avoid duplicate import (#2640) #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
requested changes
Apr 19, 2021
packages/plugin-vue/src/main.ts
Outdated
| `const _sfc_setup = _sfc_main.setup`, | ||
| `_sfc_main.setup = (props, ctx) => {`, | ||
| ` const ssrContext = useSSRContext()`, | ||
| ` const ssrContext = _useSSRContext()`, |
There was a problem hiding this comment.
We should name it __vite_useSSRContext, it is the convention for Vite internal helpers used in other places.
Note: I think we could detect the presence of useSSRContext and only inserted when needed, but this PR fixes the issue at this point and we could improve things later.
Shinigami92
added
the
p2-edge-case
patak-dev
previously approved these changes
Apr 21, 2021
Shinigami92
previously approved these changes
Apr 22, 2021
patak-dev
reviewed
Apr 22, 2021
Shinigami92
approved these changes
Apr 22, 2021
patak-dev
approved these changes
Apr 22, 2021
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2640
The plugin-vue added a line:
import { useSSRContext } from 'vue'which may duplicate with user's code
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).